-
Notifications
You must be signed in to change notification settings - Fork 194
Add support for managing languages supported by Default Setup #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main-enterprise
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Code Scanning Default Setup enforcement capabilities to safe-settings, allowing organizations to control which programming languages can be scanned by GitHub's Code Scanning Default Setup feature.
Key changes:
- New
code_scanningplugin to validate and enforce language restrictions for Code Scanning Default Setup - Schema definition for code scanning configuration with allowed/blocked language lists
- Webhook handler for
workflow_run.completedevents to trigger reactive validation - Documentation updates explaining the feature and configuration options
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| schema/settings.json | Adds JSON schema definition for code_scanning configuration with language validation enums |
| lib/settings.js | Registers the new code_scanning plugin in the plugins list |
| lib/plugins/code_scanning.js | Implements the core logic for validating and enforcing language restrictions |
| index.js | Adds webhook handler to trigger validation when Code Scanning workflows complete |
| docs/sample-settings/settings.yml | Provides example configuration for code scanning enforcement |
| README.md | Documents the feature, usage, and behavior |
Comments suppressed due to low confidence (2)
lib/plugins/code_scanning.js:3
- Unused variable MergeDeep.
const MergeDeep = require('../mergeDeep')
lib/plugins/code_scanning.js:5
- Unused variable ignorableFields.
const ignorableFields = []
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Yadhav Jayaraman <[email protected]>
Creating for collaboration and feedback